Skip to content

quote watermark column with non-zero NumPartitionsOverride #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

quote watermark column with non-zero NumPartitionsOverride #3618

merged 1 commit into from
Oct 22, 2025

Conversation

@alon-zeltser-cyera
Copy link
Contributor

@alon-zeltser-cyera alon-zeltser-cyera commented Oct 18, 2025 •
edited
Loading

Fix an issue of using PostgreSQL watermark column that contain uppercase letters for example

  "watermarkColumn": "rowInsertedAt",

and setting snapshotNumPartitionsOverride > 0, GetQRepPartitions fails with

{
  "message": "failed to get partitions from source: ERROR: column \"rowinsertedat\" does not exist (SQLSTATE 42703)",
  "source": "GoSDK",
  "cause": {
    "message": "ERROR: column \"rowinsertedat\" does not exist (SQLSTATE 42703)",
    "source": "GoSDK",
    "applicationFailureInfo": {
      "type": "PgError"
    }
  },
  "applicationFailureInfo": {
    "type": "wrapError"
  }
}

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@serprex serprex merged commit 02c9c20 into PeerDB-io:main Oct 22, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serprex serprex serprex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alon-zeltser-cyera @CLAassistant @serprex